Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update incorrect createPullSecrets reference #2750

Merged
merged 1 commit into from Nov 2, 2023

Conversation

lizardruss
Copy link
Collaborator

What issue type does this pull request address? (keep at least one, remove the others)
/kind documentation

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #2730
resovles ENG-2186

Please provide a short message that should be published in the DevSpace release notes
Fixed incorrect reference to createPullSecret in documentation.

Fixes devspace-sh#2730
Fixes ENG-2186

Signed-off-by: Russell Centanni <russell.centanni@gmail.com>
Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for devspace-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8d8c0ec
🔍 Latest deploy log https://app.netlify.com/sites/devspace-docs/deploys/65414e5b96e2be000843ecfa
😎 Deploy Preview https://deploy-preview-2750--devspace-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LISTERINE
Copy link

Change looks like it aligns with the behavior we saw. lgtm!

@lizardruss lizardruss merged commit 419d97e into devspace-sh:main Nov 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation conflict for automatic creation of pull secrets
2 participants