Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow config expressions in devspace-schema.json #2787

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

lizardruss
Copy link
Collaborator

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #2770
resolves ENG-2531

Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace json schema incorrectly shows variables and expressions as invalid.

What else do we need to know?
May also need to add variable expressions, however these cannot be used for structural changes.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for devspace-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9ded869
🔍 Latest deploy log https://app.netlify.com/sites/devspace-docs/deploys/659f68c0b1c8b100081586d3
😎 Deploy Preview https://deploy-preview-2787--devspace-docs.netlify.app/docs/configuration/dev/connections/terminal
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Fixes devspace-sh#2770

Signed-off-by: Russell Centanni <russell.centanni@gmail.com>
@FabianKramm FabianKramm merged commit b1b1d2b into devspace-sh:main Feb 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False alarms due to devspace-schema.json
2 participants