Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Make the uninstall operation idempotent #94

Closed
daniel-hutao opened this issue Dec 29, 2021 · 0 comments · Fixed by #96
Closed

Proposal: Make the uninstall operation idempotent #94

daniel-hutao opened this issue Dec 29, 2021 · 0 comments · Fixed by #96
Labels
bug Something isn't working enhancement New feature or request
Projects
Backlog
Milestone
v0.0.1

Comments

@daniel-hutao
Copy link
Member

daniel-hutao commented Dec 29, 2021 •
edited

Description

Take argocdapp as an example. If this plugin has been uninstalled, the uninstall operation will fail at this time.

Describe the Alternatives You Have Considered

Handle the error like below

Error from server (NotFound): error when deleting "./app.yaml": applications.argoproj.io "hello" not found

/kind proposal
@daniel-hutao daniel-hutao added enhancement New feature or request bug Something isn't working labels Dec 29, 2021
@daniel-hutao daniel-hutao mentioned this issue Dec 29, 2021
Closed
11 tasks
@daniel-hutao daniel-hutao added this to the v0.1.0 milestone Dec 29, 2021
@daniel-hutao daniel-hutao mentioned this issue Dec 29, 2021
Merged
@IronCore864 IronCore864 added this to To do in v0.1.0 Jan 10, 2022
@IronCore864 IronCore864 removed this from To do in v0.1.0 Jan 10, 2022
@IronCore864 IronCore864 added this to To do in Backlog via automation Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
No open projects
Backlog
To do
Milestone
v0.0.1
Development

Successfully merging a pull request may close this issue.

feat: make argocd uninstall operation idempotent
1 participant
@daniel-hutao