Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make argocd uninstall operation idempotent #96

Merged
merged 1 commit into from
Dec 29, 2021
Merged

feat: make argocd uninstall operation idempotent #96

merged 1 commit into from
Dec 29, 2021

Conversation

daniel-hutao
Copy link
Member

Signed-off-by: Daniel Hu tao.hu@merico.dev

Summary

Make argocd uninstall operation idempotent

Related Issues

#94

Do not close #94 soon after this pr's merged. argocdapp is waiting for supportting uninstall operation idempotent

Signed-off-by: Daniel Hu <tao.hu@merico.dev>
@daniel-hutao
Copy link
Member Author

image

@daniel-hutao daniel-hutao self-assigned this Dec 29, 2021
@daniel-hutao daniel-hutao added bug Something isn't working enhancement New feature or request labels Dec 29, 2021
@daniel-hutao daniel-hutao added this to the v0.1.0 milestone Dec 29, 2021
@daniel-hutao daniel-hutao mentioned this pull request Dec 29, 2021
11 tasks
@daniel-hutao daniel-hutao added this to Ready for Review in v0.1.0 Dec 29, 2021
Copy link
Contributor

@lfbdev lfbdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@daniel-hutao daniel-hutao merged commit 907a8e5 into devstream-io:main Dec 29, 2021
v0.1.0 automation moved this from Ready for Review to Done Dec 29, 2021
@daniel-hutao daniel-hutao deleted the dev-3 branch January 18, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Proposal: Make the uninstall operation idempotent
2 participants