add reinstall and unistall actions #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daniel-hutao I think it's OK if it's still a draft PR. @lfbdev, don't forget to enrich the description of the PR once you are ready to make it as "ready for review". |
|
As a rule of thumb, we don't need to review draft PRs because they are highly likely to change. |
OK, I have edited |
|
Some tips may be hidden by default. Pay attention for this. |
|
If all tests have been done, we can go ahead and merge this one now. @lfbdev @daniel-hutao |
IronCore864
approved these changes
Dec 24, 2021
deal with exception and spelling error fix the review issues
|
/lgtm |
This was referenced Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feat:
1.Implement uninstall/reinstall interface for argocdapp plugin
2.Implement uninstall/reinstall interface for githubactions plugin
for a argocdapp:
Reinstall: kubectl delete + kubectl apply again
Uninstall: kubectl delete
for a githubaction:
Reinstall: DeleteFile + CreateFile from github repo
Uninstall: DeleteFile from github repo
Key Points
Related Issues
#7 #9