Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make Makefile better #72

Merged
merged 1 commit into from
Dec 28, 2021
Merged

refactor: make Makefile better #72

merged 1 commit into from
Dec 28, 2021

Conversation

daniel-hutao
Copy link
Member

Signed-off-by: Daniel Hu tao.hu@merico.dev

Summary

make Makefile better

Description

  1. Use go mod tidy to instead of go get ./.... go mod tidy contains the work of go get ./... and does more.

Tidy makes sure go.mod matches the source code in the module.
It adds any missing modules necessary to build the current module's
packages and dependencies, and it removes unused modules that
don't provide any relevant packages. It also adds any missing entries
to go.sum and removes any unnecessary ones.

  1. Add make help command, effect like below:

image

  1. Add fmt and vet as two default action in build stage.

image

@daniel-hutao daniel-hutao mentioned this pull request Dec 27, 2021
11 tasks
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
@daniel-hutao daniel-hutao self-assigned this Dec 27, 2021
@daniel-hutao daniel-hutao added the refactor refactor label Dec 27, 2021
@daniel-hutao daniel-hutao added this to the v0.1.0 milestone Dec 27, 2021
@daniel-hutao daniel-hutao added this to Ready for Review in v0.1.0 Dec 27, 2021
@daniel-hutao
Copy link
Member Author

/cc @IronCore864 @lfbdev

@daniel-hutao daniel-hutao changed the title reflactor: make Makefile better refactor: make Makefile better Dec 27, 2021
@lfbdev
Copy link
Contributor

lfbdev commented Dec 28, 2021

/lgtm

@daniel-hutao daniel-hutao merged commit 0e710cb into devstream-io:main Dec 28, 2021
v0.1.0 automation moved this from Ready for Review to Done Dec 28, 2021
@daniel-hutao daniel-hutao deleted the reflactor-test branch January 18, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor refactor
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants