handle the function keys by preventing the default action, fixes #1367

[clarkbw]

Associated Issue: #1367

Summary of Changes

• add preventDefault and stopPropogation

Test Plan (tested in Windows only)

• Pause on breakpoint press F10 to step over

[jasonLaster]

Can we avoid stop propagation as we're listening on the window? Not much higher to go!

Also I wonder if you could add a helper

stopPropogation(() => this.stepIn())

Sorry, typing on the go.

[clarkbw]

Can we avoid stop propagation as we're listening on the window? Not much higher to go!

I tried this but I believe if you don't stop propagation the event is bubbled out of the window context because this is a key the browser / OS handles. I tried using just one or the other and it required both to be used in order to stop the default action from happening.

Also I wonder if you could add a helper

stopPropogation(() => this.stepIn())

Sounds like a good plan. Will update soon.

[jasonLaster]

strange, i've never seen this stopPropogation not present. What case are you handling here?

[clarkbw]

I was seeing an error in the console complaining that stopPropogation didn't exist while working on my Mac and I wasn't see on Windows. I'll be able to check it out on both this week some time. Not sure what's really going on here.

[jasonLaster]

hmm, i can take a look

[jasonLaster]

I dropped the if because it's part of the DOM spec lol. if we break anything we can fix it :)

https://developer.mozilla.org/en-US/docs/Web/API/Event/stopPropagation

[jasonLaster]

👍

[jasonLaster]

closing this in favor of #1455