make breakpoints more robust and improve protocol interface #222
Conversation
| return { | ||
| id: bpClient.actor, | ||
| actualLocation: actualLocation | ||
| }; |
There was a problem hiding this comment.
do we want a Breakpoint type?
There was a problem hiding this comment.
Not a bad idea, but it's a little more confusing than Source or Location because in most places a breakpoint just is a Location. The UI doesn't have any notion of a breakpointId like does a sourceId, because a Location is everything is needs to talk about breakpoints. At the protocol level we want an id and other things like actualLocation.
We could make a breakpoint type for the protocol though, with id, location, and actualLocation fields. It's clearly for the protocol, given that it has two location fields, which we can use to know if it's moved.
|
r+ Wow. That was a lot of fixes. Great job |
jlongster
force-pushed
the
better-breakpoints
branch
from
ef8d9f0
to
c125950
Compare
|
I added breakpoints types, but the actual |
Breakpoints were pretty broken before: sliding breakpoints wouldn't work, and the data returned from each client was actually a bit different. I went ahead and improved the protocol so that "breakpoint clients" are only something the Firefox client has to be concerned with now. Breakpoints should be a lot more robust: sliding works, and adding & removing seems to always work now (previously sometimes I couldn't remove a breakpoint because it got into a bad state).
I also fixed "snippets" with sliding breakpoints: previously it would show "undefined" if the breakpoint moved. Now it properly gets the text from the line that it moved to.
r?