Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Overlap breakpoints list scrollbar (#1997) #goodnessSquad #2383

Merged

Conversation

noamshemesh
Copy link
Contributor

Associated Issue: #1997

Summary of Changes

  • Fix overlapping of scrollbar on breakpoints remove button
  • Fix remove button not aligned to center
  • Fix animation issue with border-radius

Test Plan

@codecov-io
Copy link

Codecov Report

Merging #2383 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2383   +/-   ##
======================================
  Coverage       0%      0%           
======================================
  Files          77      77           
  Lines        2442    2442           
======================================
  Misses       2442    2442

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 816a59e...7c3893b. Read the comment docs.

Copy link
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @noamshemesh!

We'll test tomorrow.

Could you attach some screenshots

@noamshemesh
Copy link
Contributor Author

Sure, it's pretty hard to take a screenshot while scrolling, I hope that these two screenshots will suffice
image
image

@jasonLaster
Copy link
Contributor

Thanks!

@jasonLaster jasonLaster merged commit cb6fa8d into firefox-devtools:master Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants