Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

converted event listeners reducer to es modules #2473

Merged
merged 1 commit into from Mar 28, 2017

Conversation

Erica42
Copy link
Contributor

@Erica42 Erica42 commented Mar 28, 2017

Associated Issue: #1884

Summary of Changes

  • changed to import from require and added export

Test Plan

Tell us a little a bit about how you tested your patch.

Example test plan:

  • Command-P opens the panel
  • Clicking “+” opens the panel
  • Clicking a source navigates to the source
  • Clicking "x" closes the panel

Here's the Debugger's Testing doc
https://docs.google.com/document/d/1oBMRxV8A2ag2t22YsQOxTdEv0mXKzIg0tggJjRkU1S0/edit#.
Feel free to improve it!

Screenshots/Videos (OPTIONAL)

@jasonLaster
Copy link
Contributor

jasonLaster commented Mar 28, 2017

Thanks @Erica42! If the tests are green I'll merge it.

Any luck with webdriver?

@codecov
Copy link

codecov bot commented Mar 28, 2017

Codecov Report

Merging #2473 into master will decrease coverage by 0.15%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2473      +/-   ##
==========================================
- Coverage   54.54%   54.39%   -0.16%     
==========================================
  Files          52       52              
  Lines        2013     2015       +2     
  Branches      392      391       -1     
==========================================
- Hits         1098     1096       -2     
- Misses        915      919       +4
Impacted Files Coverage Δ
src/reducers/event-listeners.js 22.22% <50%> (-7.78%) ⬇️
src/utils/editor/index.js 11.11% <0%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc8a6b...70e90b9. Read the comment docs.

@jasonLaster
Copy link
Contributor

I'm okay with losing some of the code coverage here. I'm not even sure why this would happen :)

@jasonLaster jasonLaster merged commit 3d80b48 into firefox-devtools:master Mar 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants