Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Add void types #3157

Merged
merged 2 commits into from Jun 12, 2017
Merged

Add void types #3157

merged 2 commits into from Jun 12, 2017

Conversation

jasonLaster
Copy link
Contributor

@jasonLaster jasonLaster commented Jun 12, 2017

Associated Issue: #3156

Summary of Changes

Replace some return anys with voids. this gets us one % bump :)

@codecov
Copy link

codecov bot commented Jun 12, 2017

Codecov Report

Merging #3157 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3157   +/-   ##
======================================
  Coverage    47.4%   47.4%           
======================================
  Files          97      97           
  Lines        4014    4014           
  Branches      825     825           
======================================
  Hits         1903    1903           
  Misses       2111    2111
Impacted Files Coverage Δ
src/components/Editor/Footer.js 3.84% <ø> (ø) ⬆️
src/components/shared/ManagedTree.js 5.35% <ø> (ø) ⬆️
src/components/shared/SearchInput.js 8.69% <ø> (ø) ⬆️
src/components/shared/ObjectInspector.js 7.4% <ø> (ø) ⬆️
src/components/Editor/Preview.js 5.17% <ø> (ø) ⬆️
src/components/Editor/SearchBar.js 22.04% <ø> (ø) ⬆️
src/components/shared/Button/PaneToggle.js 7.69% <ø> (ø) ⬆️
src/components/shared/ResultList.js 100% <ø> (ø) ⬆️
src/components/Outline.js 76.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea8dccf...d5718c5. Read the comment docs.

Copy link
Contributor

@codehag codehag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codehag codehag merged commit 8c2ed12 into firefox-devtools:master Jun 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants