Fix framework grouping collapsing

[jasonLaster]

Associated Issue: #

Summary of Changes

• fixes collapsing for both frames that are not grouped

[jasonLaster]

I'd like to add a unit test here, but struggled with it

[codecov]

Codecov Report

Merging #3434 into next will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##            next    #3434      +/-   ##
=========================================
+ Coverage   49.8%   49.82%   +0.02%     
=========================================
  Files        109      109              
  Lines       4516     4516              
  Branches     930      930              
=========================================
+ Hits        2249     2250       +1     
+ Misses      2267     2266       -1

Impacted Files	Coverage Δ
src/components/SecondaryPanes/Frames/index.js	69.86% <100%> (ø)	⬆️
src/actions/ast.js	78.57% <0%> (+1.78%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fd4736...d447c15. Read the comment docs.

[codehag]

Looks good! wrote a comment to make sure I understand the fix. For the test, i would propose something like this:

describe("truncateFrames") {
  it("will truncate frames with FrameworkGrouping off") {
    const frameworkGroupingOn = false;
    const framesWithFramework = [ ... ] // datastructure
    const framesWithoutFramework = [ ... ] // datastructure
    const frames = [ ...framesWithFramework, ...framesWithoutFramework ];
    const { component } = render({ frameworkGroupingOn, frames });
    const button = component.find('button') // or whatever selector for that button

    button.simulate('click');
    expect(component.find('Frame').length).toBe(frames.length); // uncollapse
    button.simulate('click')
    expect(component.find('Frame').length).toBe(framesWithoutFramework.length + 1); // collapse
})

its a bit pseudocody... haven't tried it yet

I also tested this locally with this branch and the next branch. In the original issue it says that frames are missing, which ones should I look for?

[codehag]

Was the issue that if frameworkGroupingOn was not checked, collapse frame would be run with unexpected results?