This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Bugfix: TypeError: client.sourceContents is not a function #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codehag
commented
Jul 27, 2017
| @@ -1,16 +1,3 @@ | |||
| import { makeLocationId } from "../../../utils/breakpoint"; | |||
|
|
|||
| const sourceFixtures = { | |||
There was a problem hiding this comment.
moving this to threadClient.js so that later we can consolidate our threadclient
codehag
commented
Jul 27, 2017
| @@ -0,0 +1,116 @@ | |||
| import { makeLocationId } from "../../../utils/breakpoint"; | |||
|
|
|||
| const sourceFixtures = { | |||
There was a problem hiding this comment.
Most of the deleted code has been moved here
codehag
commented
Jul 27, 2017
| contentType: "text/javascript" | ||
| }); | ||
| break; | ||
| case "foo.js": |
Codecov Report
@@ Coverage Diff @@
## next #3472 +/- ##
==========================================
- Coverage 51.45% 51.43% -0.03%
==========================================
Files 109 109
Lines 4534 4534
Branches 938 938
==========================================
- Hits 2333 2332 -1
- Misses 2201 2202 +1
Continue to review full report at Codecov.
|
jasonLaster
pushed a commit
that referenced
this pull request
Jul 28, 2017
jasonLaster
pushed a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jul 28, 2017
jbhoosreddy
pushed a commit
to jbhoosreddy/debugger.html
that referenced
this pull request
Aug 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3421