This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Accessible collapse pane buttons #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khal0988
force-pushed
the
accessible-collapse-pane-buttons
branch
from
badaee8
to
b82e8bc
Compare
Enter/Space collapses/expands panes Buttons are reachable with the keyboard Buttons have hover/focus styling
khal0988
force-pushed
the
accessible-collapse-pane-buttons
branch
from
b82e8bc
to
1d43b3c
Compare
|
I'm not the right person to review this, I only review string changes ;-) |
|
@flodolo you got pinged because initially it had a properties change :) |
Ah, I didn't see that part. That makes more sense now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue: #4073
Summary of Changes
Test Plan
Video