This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Allow longer timeout for browser_dbg-editor-select.js #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes me a little sad, but for some reason this test runs for too long on linux debug frequently. Linux debug is a very slow machine, so it's not too surprising, but this test is not huge so I'd like to figure out what is so slow. I'm sure we'll see this in other tests eventually too and hopefully we can cross-check what these tests are doing and find a pattern of something we do a lot. Maybe pausing is slow. I know that currently we convert the whole pause packet to immutable and avoiding that will speed it up a lot, but I'd be surprised if there was this big of a perf hit.