This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Extract log into its own module to make utils avoid config dependency
#898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
devtoolsRequireproblem in the source map worker was caused by #860 because it loads theutilsfile insource.jsnow, which tries to load in our config system... You can't load the config system in the worker, nothing is set up. The only thing that needs the config system inutilsis the log function, so I extracted it out. I looked through our codebase and couldn't even find any uses of it though.Not sure if there's a better solution.