This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
Do not put a rejected promise into sourceMapRequests cache #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My previous patch in this area was mistaken - it correctly allowed errors from _fetchSourceMap to be propagated to the caller, but it also cached the rejected promise in sourceMapRequests, resulting in the same error being reported via other APIs. This patch fixes the oversight by caching a non-rejecting promise; this results in the other APIs keeping their previous behavior.
jasonLaster
approved these changes
Jul 31, 2017
There's one in M-C already. I'll see if I can write a local one though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous patch in this area was mistaken - it correctly allowed
errors from _fetchSourceMap to be propagated to the caller, but it
also cached the rejected promise in sourceMapRequests, resulting in
the same error being reported via other APIs. This patch fixes the
oversight by caching a non-rejecting promise; this results in the
other APIs keeping their previous behavior.