Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Display screenshots while hovering the thread header. #1059

Closed
wants to merge 1 commit into from

Conversation

mstange
Copy link
Contributor

@mstange mstange commented Jun 1, 2018

Just putting this up here so that we get a deploy preview.

Link to deploy preview with example profile

@codecov
Copy link

codecov bot commented Jun 1, 2018

Codecov Report

Merging #1059 into master will decrease coverage by 0.21%.
The diff coverage is 9.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
- Coverage   70.98%   70.76%   -0.22%     
==========================================
  Files         141      141              
  Lines        8312     8340      +28     
  Branches     1892     1901       +9     
==========================================
+ Hits         5900     5902       +2     
- Misses       2133     2153      +20     
- Partials      279      285       +6
Impacted Files Coverage Δ
src/components/header/TimeSelectionScrubber.js 15.58% <28.57%> (+0.51%) ⬆️
src/components/header/ProfileViewerHeader.js 29.72% <4.16%> (-47.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cf73b0...de54201. Read the comment docs.

@gregtatum
Copy link
Member

Closing since #1198 is up now.

Including a screenshot for posterity:
image

@gregtatum gregtatum closed this Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants