Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds new package for accessible tab navigation called react-tabs and a custom libdef for that package #1556

Closed

Conversation

edieblu
Copy link
Contributor

@edieblu edieblu commented Dec 13, 2018

No description provided.

@edieblu edieblu requested a review from julienw December 13, 2018 17:00
@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #1556 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1556   +/-   ##
=======================================
  Coverage   81.36%   81.36%           
=======================================
  Files         160      160           
  Lines       11163    11163           
  Branches     2764     2764           
=======================================
  Hits         9083     9083           
  Misses       1883     1883           
  Partials      197      197
Impacted Files Coverage Δ
src/components/app/MenuButtons.js 44.56% <0%> (ø) ⬆️
src/components/app/ProfileViewer.js 80% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e6571f...fe0daf5. Read the comment docs.

@edieblu edieblu changed the title Adds new package for accessible tab navigation called react-tabs and a custom libdef for that package [WIP] Adds new package for accessible tab navigation called react-tabs and a custom libdef for that package Dec 13, 2018
Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(dismissing the review, I think you picked me by mistake :) )

@julienw
Copy link
Contributor

julienw commented Dec 14, 2018

Closing the PR because we won't use it after all :) (see #1554)

@julienw julienw closed this Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants