This repository has been archived by the owner on May 2, 2018. It is now read-only.
Cleanup and small improvements #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliandescottes
approved these changes
Apr 20, 2017
src/reps/grip.js
Outdated
| }); | ||
| delete propRepProps.objectLink; | ||
| propsArray.push(PropRep(propRepProps)); | ||
| objectLink: null, |
There was a problem hiding this comment.
nit: this serves the same purpose as the title: undefined two lines above, right? Maybe group them together and use either null or undefined for both of them?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createFactorycallgetPropsfunctionPropRepfunction by not adding element for delimiter when we don't need itI think the changes are pretty small and have the same goal so I grouped them in this PR.
Feel free to ask me to split this up if you find that each commit deserve its own PR.