Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typeahead support multiple values; 2 dropdowns on deploy chart changed to typeahead #124

Merged
merged 5 commits into from
May 26, 2021

Conversation

rashmirai21
Copy link
Contributor

@rashmirai21 rashmirai21 commented May 26, 2021

Description

Deploy chart
  • Project and Environment dropdown is now typeahead.
  • Option are sorted and are searchable.
User access
  • Muti-value string is now supported in email address typeahead.
Others
  • Resource deletion button label changed to Delete
  • CD Pipeline update environment selection disabled on update

Fixes: (devtron-labs/devtron#479)
Closes: (devtron-labs/devtron#485)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Chart Deploy
  • Chart Update
  • User Save
  • User Update

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@rashmirai21 rashmirai21 changed the title Typeahead support multiple values; deploy chart dropdown changed to typeahead Typeahead support multiple values; 2 dropdowns on deploy chart changed to typeahead May 26, 2021
@nishant-d nishant-d merged commit e64b317 into main May 26, 2021
@nishant-d nishant-d deleted the add-typeahead branch May 26, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants