Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add handling for ssh authMode #1776

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

feat: add handling for ssh authMode #1776

wants to merge 43 commits into from

Conversation

AbhishekA1509
Copy link
Member

@AbhishekA1509 AbhishekA1509 commented May 23, 2024 •
edited
Loading

Description

This PR intends to bring following changes:

  • Add handling for SSH authMode in global configurations (Gitops) page.
  • Add handling for SSH authMode in app config and chart store.
  • Mark the areas for improvements in global configurations (Gitops) page.

Fixes devtron-labs/devtron#5140

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@AbhishekA1509 AbhishekA1509 self-assigned this May 23, 2024
@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label May 23, 2024
vivek-devtron
vivek-devtron reviewed May 23, 2024
View reviewed changes
src/components/gitOps/constants.ts Outdated
@@ -24,7 +24,7 @@ export const DefaultGitOpsConfig = {
active: true,
}

export const DefaultShortGitOps = {
export const DefaultShortGitOps: GitOpsState['isError'] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create separate type for this.

vivek-devtron
vivek-devtron reviewed May 23, 2024
View reviewed changes
src/components/gitOps/gitops.type.ts Outdated
AWS_CODE_COMMIT = 'AWS_CODE_COMMIT',
}

export type GitProviderType =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infer this from GitProvider

vivek-devtron
vivek-devtron reviewed May 23, 2024
View reviewed changes
src/components/gitOps/GitOpsConfiguration.tsx Outdated
@@ -51,15 +58,32 @@ const GitProviderTabIcons: React.FC<{ gitops: string }> = ({ gitops }) => {
case 'Bitbucket Cloud':
case 'Bitbucket':
return <Bitbucket />
case 'AWS Code Commit':
return <ICAwsCodeCommit className="dc__no-shrink" />
}
}

const GitProviderTab: React.FC<{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to types file

AbhishekA1509
AbhishekA1509 commented May 23, 2024
View reviewed changes
Copy link
Member Author

@AbhishekA1509 AbhishekA1509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to add url in git account selector

@github-actions github-actions bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels May 24, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems May 28, 2024
View reviewed changes
src/components/common/helpers/Helpers.tsx Dismissed Show dismissed Hide dismissed
@AbhishekA1509
Merge pull request #1784 from devtron-labs/feat/generic-gitops
f5f50eb 
feat: generic gitops
@AbhishekA1509
feat: add authMode key in GitOps
8221685
@AbhishekA1509
chore: clean up dead conditions
d41ee8d
@AbhishekA1509
fix: send bitBucketWorkspaceId only in case of isBitbucketCloud
222075b
@AbhishekA1509
fix: hide update confirmation modal in case of zero state
ae929b9
@AbhishekA1509
revert: user gitops flag
86cc40b
@AbhishekA1509
chore: remove unnecesary comment
06b04b7
@AbhishekA1509
fix: git provider tab change will not propagate repoType
8f06948
@AbhishekA1509
fix: authmode check in handleGitopsTab
c04abe7
@AbhishekA1509
fix: add fallback check for authMode in api request
3602c04
@AbhishekA1509
fix: getFormErrors for sshKey and token
9832cab
@AbhishekA1509
feat: add dc__truncate--clamp-6
420e69f
@AbhishekA1509
fix: label for bitbucket host
9c6c214
@AbhishekA1509
fix: abstract isAuthModeSSH into method
1d236c8
@AbhishekA1509
fix: add check for required field in bitbucket project key
6ca7892
@AbhishekA1509
fix: make project key optional in bitbucket
f37f49c
@AbhishekA1509
revert: make project id for bitbucket mandatory
2dea686
@AbhishekA1509
fix: remove bitbucket optional project subtitle
9a2fad4
@AbhishekA1509
feat: hide validate form in case selectedRepoType is not default
71e0608
@AbhishekA1509
Merge pull request #1804 from devtron-labs/feat/bitbucket-dc
1c9c1a6 
feat: bitbucket dc
@AbhishekA1509
Merge branch 'main' into feat/aws-code-commit
8a67202
@AbhishekA1509
fix: remove unused import
482bd9b
@AbhishekA1509
fix: add default authMode
3834386
@AbhishekA1509
Merge branch 'main' into feat/aws-code-commit
4b32b0d
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivek-devtron vivek-devtron vivek-devtron left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@AbhishekA1509 AbhishekA1509

Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: AWS Code commit support in Git account
2 participants
@AbhishekA1509 @vivek-devtron