Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devtron header #377

Merged
merged 20 commits into from May 25, 2022
Merged

Devtron header #377

merged 20 commits into from May 25, 2022

Conversation

shivani170
Copy link
Contributor

Description

To make all the headers in the dashboard uniform components including:

  1. App List
  2. Global Configuration
  3. Deployment Group

Screenshot 2022-05-18 at 2 59 43 PM

Fixes devtron-labs/devtron#1682

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested in App List
  • Tested in Deployment Group
  • Tested in Bulk Edits

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@shivani170 shivani170 self-assigned this May 23, 2022
@pghildiyal pghildiyal merged commit 99e3ebe into main May 25, 2022
@pghildiyal pghildiyal deleted the devtron-header branch May 25, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pghildiyal pghildiyal pghildiyal approved these changes

@vivek-devtron vivek-devtron vivek-devtron approved these changes

Assignees

@shivani170 shivani170

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FE] Uniformity in Devtron Headers throughout the dashboard 01
3 participants
@shivani170 @pghildiyal @vivek-devtron