fix for group-delete fix (#3609)

devtron-labs · Jul 12, 2023 · e9223a6 · e9223a6
1 parent 3f2a505
commit e9223a6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/user/RoleGroupService.go b/pkg/user/RoleGroupService.go
@@ -610,7 +610,7 @@ func (impl RoleGroupServiceImpl) DeleteRoleGroup(bean *bean.RoleGroup) (bool, er
 	if err != nil {
 		impl.logger.Errorw("error in getting all role group role mappings or not found", "err", err)
 	}
-	allRolesForGroup, err := impl.roleGroupRepository.GetRolesByGroupCasbinName(model.CasbinName)
+	allRolesForGroup, err := casbin2.GetRolesForUser(model.CasbinName)
 	if err != nil {
 		impl.logger.Errorw("error in getting all roles for groups", "err", err)
 	}
@@ -644,7 +644,7 @@ func (impl RoleGroupServiceImpl) DeleteRoleGroup(bean *bean.RoleGroup) (bool, er
 	}
 
 	for _, role := range allRolesForGroup {
-		flag := casbin2.DeleteRoleForUser(model.CasbinName, role.Role)
+		flag := casbin2.DeleteRoleForUser(model.CasbinName, role)
 		if flag == false {
 			impl.logger.Warnw("unable to delete mapping of group and user in casbin", "user", model.CasbinName, "role", role)
 			return false, err