fix: Update cd pipeline create empty pre post cd steps (#4113)

* check for active ci_pipeline_material * check for len of steps * check for len of steps
devtron-labs · Oct 17, 2023 · ffb2390 · ffb2390
1 parent 81e24a0
commit ffb2390
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/pkg/pipeline/PipelineStageService.go b/pkg/pipeline/PipelineStageService.go
@@ -964,10 +964,12 @@ func (impl *PipelineStageServiceImpl) UpdatePipelineStage(stageReq *bean.Pipelin
 	if err == pg.ErrNoRows || createNewPipStage {
 		//no stage found, creating new stage
 		stageReq.Id = 0
-		err = impl.CreatePipelineStage(stageReq, stageType, pipelineId, userId)
-		if err != nil {
-			impl.logger.Errorw("error in creating new pipeline stage", "err", err, "pipelineStageReq", stageReq)
-			return err
+		if len(stageReq.Steps) > 0 {
+			err = impl.CreatePipelineStage(stageReq, stageType, pipelineId, userId)
+			if err != nil {
+				impl.logger.Errorw("error in creating new pipeline stage", "err", err, "pipelineStageReq", stageReq)
+				return err
+			}
 		}
 	} else {
 		//stageId found, to handle as an update request