Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add key to component & open InputVariables in pre/post build modal #1770

Merged
merged 3 commits into from
May 21, 2024

Conversation

Elessar1802
Copy link
Contributor

@Elessar1802 Elessar1802 commented May 21, 2024

Description

By default now the input variables field will be expanded whenever a plugin is opened in the pre/post build modal

Also fixed the issue where react-select was internally retaining the state between the pre & post build tabs.

Fixes devtron-labs/devtron#5142

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label May 21, 2024
@Elessar1802 Elessar1802 changed the title fix: add key to component fix: add key to component & open InputVariables in pre/post build modal May 21, 2024
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions github-actions bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels May 21, 2024
@Elessar1802 Elessar1802 merged commit 3804c4f into main May 21, 2024
11 of 13 checks passed
@Elessar1802 Elessar1802 deleted the fix/pre-build branch May 21, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: wrong image showed while switching in pre and post build stage
2 participants