Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Gitops optional for cicd #1861

Merged
merged 9 commits into from
Jun 13, 2022
Merged

Feat: Gitops optional for cicd #1861

merged 9 commits into from
Jun 13, 2022

Conversation

vikramdevtron
Copy link
Contributor

@vikramdevtron vikramdevtron commented Jun 10, 2022

Description

Gitops now optional, without configuration you can use CICD feature. This also include the backward compatibility in case gitops configured so previously created apps are handle in same way as without gitops.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • App workflow
  • Cd pipeline create without gitops and with gitops
  • CD pipeline trigger for both help type and acd type.
  • CD pipeline delete both helm and acd type pipeline.
  • App detail - resource tree
  • App workflow - cd pipeline status

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles
  • I have added all the required unit/api test cases

api/restHandler/AppListingRestHandler.go Outdated Show resolved Hide resolved
api/restHandler/common/apiError.go Outdated Show resolved Hide resolved
internal/util/ChartService.go Outdated Show resolved Hide resolved
pkg/app/AppService.go Outdated Show resolved Hide resolved
@nishant-d nishant-d merged commit 7b5f5f1 into main Jun 13, 2022
@nishant-d nishant-d deleted the gitops-optional-for-cicd branch June 13, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment