feat: pod manifest edit feature and option to connect session with node debug pod. #3116
Conversation
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 141558 | Generic High Entropy Secret | fde8a1e | scripts/devtron-reference-helm-charts/statefulset-chart_4-18-0/env-values.yaml | View secret |
| 2763127 | Generic High Entropy Secret | fde8a1e | scripts/devtron-reference-helm-charts/statefulset-chart_4-18-0/secrets-test-values.yaml | View secret |
| 141558 | Generic High Entropy Secret | ba72399 | scripts/devtron-reference-helm-charts/cronjob-chart_1-5-0/env-values.yaml | View secret |
| 2763127 | Generic High Entropy Secret | ba72399 | scripts/devtron-reference-helm-charts/cronjob-chart_1-5-0/secrets-test-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
| deleteOptions := metav1.DeleteOptions{} | ||
| if request.ForceDelete { | ||
| var gracePeriodSeconds int64 = 0 | ||
| deleteOptions.GracePeriodSeconds = &gracePeriodSeconds |
There was a problem hiding this comment.
we can use pointer.Int64Ptr here
pkg/terminal/terminalSesion.go
Outdated
| impl.logger.Errorw("error in fetching config", "err", err) | ||
| return nil, nil, err | ||
| } | ||
| impl.logger.Infow("reached getExecutor method call") |
There was a problem hiding this comment.
do we need these, If Yes, then Please change Loglevel to Debug
|
SonarCloud Quality Gate failed.
|
Description
Added pod manifest edit feature and option to connect session with node debug pod.
Fixes #3597
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?