Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: workflow refactoring #3714

Merged
merged 78 commits into from
Sep 26, 2023
Merged

chore: workflow refactoring #3714

merged 78 commits into from
Sep 26, 2023

Conversation

adi6859
Copy link
Contributor

@adi6859 adi6859 commented Jul 31, 2023

Description

Refactoring of cdWorkflow , ciWorkflow , ciConfig ,cdConfig

How Has This Been Tested?

All Tests are performed locally and by deploying image on VM

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@gitguardian
Copy link

gitguardian bot commented Sep 4, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
7993270 Generic High Entropy Secret 6b7552d pkg/pipeline/WorkflowServiceIT_test.go View secret
7993270 Generic High Entropy Secret 51c38dc pkg/pipeline/WorkflowServiceIT_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@Ashish-devtron Ashish-devtron changed the title feat: workflow refactoring chore: workflow refactoring Sep 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 26 Code Smells

No Coverage information No Coverage information
17.4% 17.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Ashish-devtron Ashish-devtron merged commit ed53d84 into main Sep 26, 2023
5 of 6 checks passed
@Ashish-devtron Ashish-devtron deleted the workflow-refactoring-final branch September 26, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants