Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rbac fix terminal connection on view and edit in helm apps #3723

Merged
merged 6 commits into from
Aug 14, 2023
Merged

fix: rbac fix terminal connection on view and edit in helm apps #3723

merged 6 commits into from
Aug 14, 2023

Conversation

Shivam-nagar23
Copy link
Member

@Shivam-nagar23 Shivam-nagar23 commented Aug 3, 2023 •
edited

Description

Fixes #3761
We were able to connect to terminal in case of helm apps with sub-user having permission of view and edit.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@Shivam-nagar23 Shivam-nagar23 changed the title Fix: rbac fix terminal connection on view and edit in helm apps fix: rbac fix terminal connection on view and edit in helm apps Aug 14, 2023
@Shivam-nagar23 Shivam-nagar23 linked an issue Aug 14, 2023 that may be closed by this pull request
Bug: User Having "View & Edit" permission is not able to delete resources of the application but he can connect to terminal #3761
Closed
2 tasks
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Shivam-nagar23 Shivam-nagar23 merged commit 20a4708 into main Aug 14, 2023
5 of 6 checks passed
@Shivam-nagar23 Shivam-nagar23 deleted the rbac-fix-terminal branch August 14, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartik-579 kartik-579 kartik-579 approved these changes

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
3 participants
@Shivam-nagar23 @kartik-579 @prakarsh-dt