Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Showing port number instead of string port_number. #3729

Merged
merged 12 commits into from
Aug 11, 2023

Conversation

dhananjay0601
Copy link
Contributor

@dhananjay0601 dhananjay0601 commented Aug 7, 2023

Description

We have to show the port number (integral value) for the services in app details page instead of the string port_number placeholder.

Fixes #3741

How Has This Been Tested?

  • This has been tested by validating the corresponding response from the resource tree which contains the additional field for the port number

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

@gitguardian
Copy link

gitguardian bot commented Aug 7, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
7592481 Generic High Entropy Secret 1a6751e api/restHandler/AppListingRestHandler.go View secret
7592481 Generic High Entropy Secret 37b298b api/restHandler/AppListingRestHandler.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@prakarsh-dt prakarsh-dt changed the title fix: Showing port number instead of string port_number fix: Showing port number instead of string port_number. Aug 7, 2023
@prakarsh-dt prakarsh-dt changed the title fix: Showing port number instead of string port_number. fix: Showing port number instead of string port_number Aug 7, 2023
@prakarsh-dt prakarsh-dt changed the title fix: Showing port number instead of string port_number fix: Showing port number instead of string port_number. Aug 7, 2023
@prakarsh-dt prakarsh-dt changed the title fix: Showing port number instead of string port_number. fix: Showing port number instead of string port_number Aug 7, 2023
vikramdevtron
vikramdevtron previously approved these changes Aug 8, 2023
@prakarsh-dt prakarsh-dt changed the title fix: Showing port number instead of string port_number fix: Showing port number instead of string port_number. Aug 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dhananjay0601 dhananjay0601 merged commit 59686b3 into main Aug 11, 2023
5 of 7 checks passed
@dhananjay0601 dhananjay0601 deleted the port_number_placeholder branch August 11, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Show Actual port number instead of string PortNumber in placeholder
3 participants