fix: Intermittent helm apps deployment fail deployed through gitops #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kartik-579
requested changes
Aug 14, 2023
| } | ||
| err = impl.AddConfigFileToChart(valuesConfig, dir, clonedDir) | ||
| if err != nil { | ||
| impl.logger.Errorw("error in adding requirements.yaml to chart", "err", err, "appName", PushChartToGitRequest.AppName) |
| } | ||
| } | ||
| impl.logger.Debugw("template committed", "url", PushChartToGitRequest.RepoURL, "commit", commit) | ||
| defer impl.chartTemplateService.CleanDir(clonedDir) | ||
| return &util.ChartGitAttribute{RepoUrl: PushChartToGitRequest.RepoURL, ChartLocation: filepath.Join("", acdAppName)}, nil | ||
| return &util.ChartGitAttribute{RepoUrl: PushChartToGitRequest.RepoURL, ChartLocation: filepath.Join("", acdAppName)}, commit, err |
There was a problem hiding this comment.
what difference is empty string making in filepath.Join?
|
@Shivam-nagar23 two checks are failing - Validate Pull Request and Semantic PR. Please have them fixed. |
Shivam-nagar23
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
kartik-579
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Intermittent helm apps deployment fail deployed through gitops
Fixes #3716
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?