Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Maintaining audit logs #3763

Merged
merged 38 commits into from
Sep 1, 2023
Merged

feat: Maintaining audit logs #3763

merged 38 commits into from
Sep 1, 2023

Conversation

dhananjay0601
Copy link
Contributor

@dhananjay0601 dhananjay0601 commented Aug 16, 2023

Description

Maintaining Audit log for each API call so that it would significantly elevate its functionality and security.

Fixes #3665

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


api/logger/bean.go Outdated Show resolved Hide resolved
api/logger/logger.go Outdated Show resolved Hide resolved
api/logger/logger.go Outdated Show resolved Hide resolved
api/logger/logger.go Outdated Show resolved Hide resolved
api/logger/logger.go Outdated Show resolved Hide resolved
vikramdevtron
vikramdevtron previously approved these changes Aug 25, 2023
vikramdevtron
vikramdevtron previously approved these changes Aug 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vikramdevtron vikramdevtron merged commit d6c81b8 into main Sep 1, 2023
6 checks passed
@vikramdevtron vikramdevtron deleted the maintaining_audit_logs branch September 1, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Basic Audit logs on Devtron UI
5 participants