Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deployment timelines fix for helm apps #3794

Merged
merged 5 commits into from
Aug 23, 2023
Merged

fix: deployment timelines fix for helm apps #3794

merged 5 commits into from
Aug 23, 2023

Conversation

Shivam-nagar23
Copy link
Member

@Shivam-nagar23 Shivam-nagar23 commented Aug 18, 2023 •
edited
Loading

Description

Fixes #3783

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@Shivam-nagar23 Shivam-nagar23 linked an issue Aug 21, 2023 that may be closed by this pull request
Bug: Deployment status are not visible properly for helm apps managed by gitops #3783
Closed
2 tasks
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Shivam-nagar23 Shivam-nagar23 merged commit f1cf1ba into main Aug 23, 2023
5 checks passed
@Shivam-nagar23 Shivam-nagar23 deleted the gitops-helm-timeline-fix branch August 23, 2023 07:44
@kamal-devtron kamal-devtron mentioned this pull request Sep 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakash100198 prakash100198 prakash100198 approved these changes

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Deployment status are not visible properly for helm apps managed by gitops
3 participants
@Shivam-nagar23 @prakash100198 @prakarsh-dt