feat: custom chart download #3801
Conversation
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 7786970 | Generic High Entropy Secret | 7af7645 | api/appStore/deployment/AppStoreDeploymentRestHandler.go | View secret |
| 7786970 | Generic High Entropy Secret | 3ada5a2 | api/appStore/deployment/AppStoreDeploymentRestHandler.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
| // common.WriteJsonResp(w, err, nil, http.StatusInternalServerError) | ||
| // return | ||
| //} | ||
| ctx = context.WithValue(r.Context(), "token", "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJleHAiOjE2OTIzNTM3MDYsImp0aSI6IjcwNDIzOTRjLTQwNDktNDVjMi05MWE0LTkxZDViYjEwNDJmNCIsImlhdCI6MTY5MjI2NzMwNiwiaXNzIjoiYXJnb2NkIiwibmJmIjoxNjkyMjY3MzA2LCJzdWIiOiJhZG1pbiJ9.gSWm-GbKY4I1Svg5xOGsrVRGSAAvdBC7S8iIlomfL9I") |
|
|
||
| token := r.Header.Get("token") | ||
| if ok := handler.enforcer.Enforce(token, casbin.ResourceGlobal, casbin.ActionDelete, "*"); !ok { | ||
| common.WriteJsonResp(w, errors.New("unauthorized"), nil, http.StatusForbidden) |
There was a problem hiding this comment.
Have used ActionUpdate
| common.WriteJsonResp(w, fmt.Errorf("error in parsing chartRefId : %s must be integer", chartRefId), nil, http.StatusBadRequest) | ||
| return | ||
| } | ||
| chartRef, err := handler.chartService.FetchChartInfoByChartRefId(chartRefId) |
There was a problem hiding this comment.
we should move this logic of fetching chart and converting it into bytes in a separate function in chart service
|
Kudos, SonarCloud Quality Gate passed!
|
Description
Problem Statement:
Inability to Download Uploaded Helm Charts on Devtron Hinders Chart Modifications and Re-uploads.
Solution:
Fixes #3840
Invalid Chart Name: lower(Reserved_Names) has prefix
Reserved_Names_Examples
Rollout Deployment/ Rollout_Deployment/ Rollout.Deployment/ Rollout-Deployment/rollout deployment/ rollout_deployment/ rollout.deployment/ rollout-deployment/ Reference Chart/ Reference_Chart/ Reference.Chart/ Reference-Chart/reference.chart/ reference-chart
Deployment/ deployment/ Deployment Chart/Deployment_Chart/Deployment.Chart/Deployment-Chart/deployment.chart/ deployment-chart
Knative/ knative/ Knative Chart/ Knative_Chart/ Knative.Chart/ Knative-Chartknative.chart/ knative-chart
Job & CronJob/ job & cronjob/job_&_cronjob/Cronjob Chart/Cronjob_Chart/Cronjob.Chart/ Cronjob-Chartcronjob.chart/ cronjob-chart
StatefulSet/ statefulset/ statefulset.chart/ statefulset-chart
How Has This Been Tested?
Checklist:
Does this PR introduce a user-facing change?