Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deleting pipeline stage and related data if no stage steps are found #3832

Merged
merged 11 commits into from
Aug 30, 2023
Merged

fix: deleting pipeline stage and related data if no stage steps are found #3832

merged 11 commits into from
Aug 30, 2023

Conversation

gireesh-devtron
Copy link
Member

@gireesh-devtron gireesh-devtron commented Aug 25, 2023 •
edited

Description

Fixes #3826

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

prakash100198
prakash100198 previously approved these changes Aug 29, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
17.9% 17.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@gireesh-devtron gireesh-devtron changed the title fix: added deleteStage pipeline and related data if no steps are found fix: deleting pipeline stage and related data if no stage steps are found Aug 30, 2023
@gireesh-devtron gireesh-devtron merged commit 87658a1 into main Aug 30, 2023
7 of 8 checks passed
@gireesh-devtron gireesh-devtron deleted the pipeline-stage-delete branch August 30, 2023 09:11
@kamal-devtron kamal-devtron mentioned this pull request Sep 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakash100198 prakash100198 prakash100198 approved these changes

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Applciation not deploying automatically even though trigger type is set to auto
4 participants
@gireesh-devtron @prakash100198 @kripanshdevtron @prakarsh-dt