Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added validation for create app workflow API #3842

Merged
merged 11 commits into from
Sep 6, 2023
Merged

Conversation

Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Aug 29, 2023

Description

The API for creating Devtron App Workflow : /orchestrator/core/v1beta1/application/workflow, will create invalid CI Material incase of linked CI if the payload contains invalid GitMaterialId. As it creates the workflow successfully with corrupted data, we will not be able to update branch name in linked CI pipeline. This PR adds validation to the createAppWorkflow API

Fixes #3827

How Has This Been Tested?

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@Ash-exp Ash-exp added the enhancement New feature or request label Aug 29, 2023
@Ash-exp Ash-exp self-assigned this Aug 29, 2023
iamayushm
iamayushm previously approved these changes Aug 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ash-exp Ash-exp merged commit b92056d into main Sep 6, 2023
5 checks passed
@Ash-exp Ash-exp deleted the fix-clone-workflow branch September 6, 2023 14:44
Shivam-nagar23 pushed a commit that referenced this pull request Sep 12, 2023
* feat: added validation for create app workflow

* fixed: CiPipelineDetails validation

* fixed: virtual env validation

* fixed: validation struct

* fixed: validation struct

* fixed: validation struct

* chore: renamed a function

* fixed: updated validation

* updated: validation for linked CI
vikramdevtron added a commit that referenced this pull request Sep 13, 2023
* rbac-modification

* rbac modification changes

* handling conditiin of empty envs

* refactoring and rbac in description

* refactoring

* rbac chaneg for node detail and node list

* Refactoring into rbacClusterService

* review change

* added new api for api resources gvk list

* fix makefile for shallow clone release

* added: migration script (#3870)

* feat: added validation for create app workflow API (#3842)

* feat: added validation for create app workflow

* fixed: CiPipelineDetails validation

* fixed: virtual env validation

* fixed: validation struct

* fixed: validation struct

* fixed: validation struct

* chore: renamed a function

* fixed: updated validation

* updated: validation for linked CI

* feat: deployment history release not found err handling (#3811)

* query optimised (#3877)

* fixed: deployment history user details (#3873)

* chore: adjust duplicate action threshold (#3879)

---------

Co-authored-by: Vikram Singh <vikram@devtron.ai>
Co-authored-by: Asutosh Das <asutosh2000ad@gmail.com>
Co-authored-by: Gireesh Naidu <111440205+gireesh-devtron@users.noreply.github.com>
Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: API for creating Devtron App Workflow, creates Invalid GitMaterial incase of linked CI (No validations)
3 participants