fix: Makefile correction #3852
Merged
fix: Makefile correction #3852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -27,10 +27,11 @@ build: clean wire | |||
| -X 'github.com/devtron-labs/devtron/util.ServerMode=${SERVER_MODE_FULL}'" | |||
|
|
|||
| wire: | |||
| export GOFLAGS=-buildvcs=false | |||
There was a problem hiding this comment.
is this backward compatible, will this work on prior releases than shallow clone
There was a problem hiding this comment.
yes it's backward compatible
vikramdevtron
approved these changes
Sep 1, 2023
subhashish-devtron
pushed a commit
that referenced
this pull request
Sep 14, 2023
* GOFLAGS flag introduced in * ea makefile fix
Ash-exp
pushed a commit
that referenced
this pull request
Sep 27, 2023
* add core functions * added the branch change API * Add unit tests * Allow source change only in customApp * Refactor tests * Add logs * Refactor API * Add API to change chart ref id * Find app metrics * Fix issues * Patch winter soldier config * Add flaggerCanary Check * Add error message when env.Ovverride is not set * Add source type check * Add Spec for /orchestrator/app/ci-pipeline/patch-source * Refactor and add spec * added variable repo and service for entity mapping and history * added audit * added markers for integration points * repository file added * added markers for gojson validatipn for templates * using variable names instead of ids * var template resolve * ScopedVariableService.go added * folder structure changed * changes in bean file added * UTs * adding integrations * files added for restHandler and router * signature change * working build * merged main and added integrations(partial) for config drafts * added missing mappings * bug fixed in variable definition * tested for scoped variable * nil pointer handled * fixes and tests * quotes handling in template added * fixes * fixes and tests * parse template as stringify template * json function added * gloval variable not getting saved issues fixed * issue in GetScopedVariableDataForVarIds fixed * delete functionality added * handle defaulted variables * testing fixes * testing fixes * getting global variable issue fixed * get scopeVariable function merged * adding len check * removed argo-cd assets copy, will fix later * removed enity from validate * added dockerfile update * validation added * validation added * error handled for scope * validation added for complex datatype * file for schema json added * nil value for payload added in case of empty variable * error handling in rest handler * resolved vars history * yaml validator added * validation for character length added * more test cases * passing cluster ID in config draft for scope resolution * primitive type validation added * differentiator added for string * adding spec version check * code refactored around variable definition * bug fix * sync dependencies * added new spec with transformer * type string to int * bug fixed around getting scoped variable * bug fixed around getting scoped variable * bug fixed around transformer * minor type change * scope fix for latest saved config * dockerfile * sql down script added and some function moved to helper * Revert "dockerfile" This reverts commit ecf8637. * env driven validation added * added argo-cd asssets in vendor from main * logger message added * selector spec fix * fix no variables found case * fixes * omitempty added for selectors * validation removed for Selectors * issue fixed around getting json * variable type handling * toInt and toBool func registered * json template parsing * json parser fix * variable parser fix * logging fix * variable value duplication issue fixed * variable service refactoring * high level refactoring scopedvariableservice * getting env repo call for clusterId removed * cleaning and optimizing getScoped Data * fix nil array * go mod vendor * refactoring variable helper * cleaned comments * added cache handling for getJson * extended compounded qualifier logic for finding matched scope * unit test case added for createVariable and IsValidPayload method * bug fixes * fix: Makefile correction (#3852) * GOFLAGS flag introduced in * ea makefile fix * bug fixes * feat: scoped vars squashed * synced changes from feature branch d9bd011^..116728c * getScoped variable with Details handling * fixed logic for get scoped repo call * enterprise sync * added missing vendor files from main * validation-error file added for showing error code 406 for validation * validation-error file added for showing error code 406 for validation * all test cases added for scoped variable service * variable template parser * oss sync miss * refactored parseTemplate changes incorporated * commented out duplicate test case * short description and isSensitive is added * pointer handling * check added for superadmin to show data * *** added in case of private variable * test cases added for private variable * test cases updated for private variable * isRedacted is added for FE handling * some code review changes done * varType to Variable type * name of documentation and description has been changed * fixing last deployed deployment bug introduced after template parser code changes * fixing last deployed deployment bug introduced after template parser code changes * QA bug fix * minor code cleaning * typo fix * cleaning dead comments --------- Co-authored-by: Avdhesh Kumar <avdhesh@devtron.ai> Co-authored-by: avdhesh-devtron <138586469+avdhesh-devtron@users.noreply.github.com> Co-authored-by: adi6859 <aditya.ar1909@gmail.com> Co-authored-by: Kripansh <kripansh@devtron.ai> Co-authored-by: Prakash <prakash.kumar@devtron.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3853
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?