Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add plugin via api #3937

Merged
merged 43 commits into from
Nov 17, 2023
Merged

feat: add plugin via api #3937

merged 43 commits into from
Nov 17, 2023

Conversation

prakash100198
Copy link
Contributor

@prakash100198 prakash100198 commented Sep 20, 2023 •
edited

Description

This pr aims at new feature where a user can add new plugin via api.
Fixes #4236

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@prakash100198 prakash100198 marked this pull request as ready for review September 24, 2023 12:13
kartik-579
kartik-579 requested changes Oct 4, 2023
View reviewed changes
api/router/GlobalPluginRouter.go Outdated Show resolved Hide resolved
api/restHandler/GlobalPluginRestHandler.go Outdated Show resolved Hide resolved
api/restHandler/GlobalPluginRestHandler.go Show resolved Hide resolved
api/restHandler/GlobalPluginRestHandler.go Outdated Show resolved Hide resolved
api/restHandler/GlobalPluginRestHandler.go Show resolved Hide resolved
pkg/plugin/GlobalPluginService.go Outdated Show resolved Hide resolved
pkg/plugin/GlobalPluginService.go Outdated Show resolved Hide resolved
pkg/plugin/GlobalPluginService.go Outdated Show resolved Hide resolved
pkg/plugin/GlobalPluginService.go Outdated Show resolved Hide resolved
pkg/plugin/GlobalPluginService.go Show resolved Hide resolved
kartik-579
kartik-579 requested changes Oct 5, 2023
View reviewed changes
pkg/plugin/GlobalPluginService.go Outdated Show resolved Hide resolved
pkg/plugin/GlobalPluginService.go Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prakash100198 prakash100198 merged commit 606a16c into main Nov 17, 2023
8 checks passed
@prakash100198 prakash100198 deleted the add-plugin-via-api branch November 17, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron left review comments

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

@kartik-579 kartik-579 kartik-579 left review comments

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Adding plugin via API support
5 participants
@prakash100198 @vikramdevtron @kartik-579 @kripanshdevtron @prakarsh-dt