fix: pipelineOverride id being sent instead of pipelineId #3984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
kartik-579
changed the title
Shivam-nagar23
pushed a commit
that referenced
this pull request
Sep 29, 2023
Shivam-nagar23
added a commit
that referenced
this pull request
Sep 29, 2023
* trigger Ci Cron * changes for adding job in devtron apps * port-fix * setting flag in pipeline db * fix ecr repo save condition * fix corrupt data save * adding build context git material id * pg no rows fix * plugin support * plugin support * trigger ci for JOB_Ci * use const * remove only git material from ciMaterial * Logging ci complete event * vendor-update * icon for plugin * get plugin Id from name * revert connection.go port * sorting only latest image * logs and script addition * script number change * update envDefault * docker parameters * docker repo create enable * update envDefault * sent last fetch artifact time * change SourceControllerCronTime env * change type for cron * change query * image update * review comments * review comments * review comments * image plugin change * update down script * pipeline type flag * flag in app group api * script update * comments * script change * app clone handle * fixed ci pod request (#3980) * fixed pipelineOverride id being sent instead of pipelineId (#3984) * chore: added CODEOWNERS (#3966) * added CODEOWNERS file * updated CODEOWNERS file * Update CODEOWNERS * Update CODEOWNERS --------- Co-authored-by: Shubham9t9 <shubhamkumar47022@gmai.com> Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> --------- Co-authored-by: Ashish-devtron <ashish.kumar@devtron.ai> Co-authored-by: ayushmaheshwari <ayush@devtron.ai> Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com> Co-authored-by: Shubham Kumar <87755583+Shubham9t9@users.noreply.github.com> Co-authored-by: Shubham9t9 <shubhamkumar47022@gmai.com> Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com>
ShashwatDadhich
pushed a commit
that referenced
this pull request
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For Post CD stage trigger, pipelineOverrideId was being sent instead of pipelineId causing post cd stage trigger to not work in automatic mode.
Fixes #3985
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?