Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Port service mapping #4058

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: Port service mapping #4058

wants to merge 8 commits into from

Conversation

dhananjay0601
Copy link
Contributor

Description

Issue with service URL and port numbers

Fixes #4025

How Has This Been Tested?

  • By deploying the helm and Agrocd app with multiple services.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamayushm iamayushm Awaiting requested review from iamayushm

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron kripanshdevtron is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: issue with service URL and port numbers
1 participant
@dhananjay0601