Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: normal Refresh after triggering gitops deployment to avoid sync delay in argo #4066

Merged
merged 11 commits into from
Oct 18, 2023
Merged

fix: normal Refresh after triggering gitops deployment to avoid sync delay in argo #4066

merged 11 commits into from
Oct 18, 2023

Conversation

Shivam-nagar23
Copy link
Member

@Shivam-nagar23 Shivam-nagar23 commented Oct 11, 2023 •
edited

Description

Fixes #4046

Above issue is being resolved with this PR, doing a refresh on argocd will do a sync.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@prakarsh-dt prakarsh-dt linked an issue Oct 12, 2023 that may be closed by this pull request
Feature: Support for ArgoCD webhook #4046
Closed
2 tasks
@Shivam-nagar23 Shivam-nagar23 changed the title enhancement: normal Refresh after triggering gitops deployment to avoid sync delay in argo fix: normal Refresh after triggering gitops deployment to avoid sync delay in argo Oct 18, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Shivam-nagar23 Shivam-nagar23 merged commit 7a40944 into main Oct 18, 2023
5 checks passed
@Shivam-nagar23 Shivam-nagar23 deleted the refresh-for-argocd branch October 18, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@kartik-579 kartik-579 kartik-579 approved these changes

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron kripanshdevtron is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Support for ArgoCD webhook
3 participants
@Shivam-nagar23 @vikramdevtron @kartik-579