Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update cd pipeline create empty pre post cd steps #4113

Merged
merged 9 commits into from
Oct 17, 2023
Merged

fix: Update cd pipeline create empty pre post cd steps #4113

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7418f2b
check for active ci_pipeline_material
Ashish-devtron Oct 11, 2023
78b844f
t checkout ci-pipeMerge branch 'main' of github.com:devtron-labs/devtron
Ashish-devtron Oct 11, 2023
2b0ca95
Merge branch 'main' of github.com:devtron-labs/devtron
Ashish-devtron Oct 12, 2023
f7ce0ff
Merge branch 'main' of github.com:devtron-labs/devtron
Ashish-devtron Oct 12, 2023
7a9a8a9
Merge branch 'main' of github.com:devtron-labs/devtron
Ashish-devtron Oct 13, 2023
3b0ac36
Merge branch 'main' of github.com:devtron-labs/devtron
Ashish-devtron Oct 17, 2023
804ee25
Merge branch 'main' of github.com:devtron-labs/devtron
Ashish-devtron Oct 17, 2023
d422120
check for len of steps
Ashish-devtron Oct 17, 2023
f4cf990
check for len of steps
Ashish-devtron Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions pkg/pipeline/PipelineStageService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,10 +964,12 @@ func (impl *PipelineStageServiceImpl) UpdatePipelineStage(stageReq *bean.Pipelin
if err == pg.ErrNoRows || createNewPipStage {
//no stage found, creating new stage
stageReq.Id = 0
err = impl.CreatePipelineStage(stageReq, stageType, pipelineId, userId)
if err != nil {
impl.logger.Errorw("error in creating new pipeline stage", "err", err, "pipelineStageReq", stageReq)
return err
if len(stageReq.Steps) > 0 {
err = impl.CreatePipelineStage(stageReq, stageType, pipelineId, userId)
if err != nil {
impl.logger.Errorw("error in creating new pipeline stage", "err", err, "pipelineStageReq", stageReq)
return err
}
}
} else {
//stageId found, to handle as an update request
Expand Down