fix: port service mapping #4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishdevtron
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
vikramdevtron
previously approved these changes
Oct 19, 2023
kartik-579
reviewed
Oct 19, 2023
pkg/k8s/K8sCommonService.go
Outdated
| @@ -496,15 +524,25 @@ func (impl K8sCommonServiceImpl) PortNumberExtraction(resp []BatchResourceRespon | |||
| impl.logger.Warnw("value not found in resourceTreeVal, unable to extract port no") | |||
| continue | |||
| } | |||
| serviceNameRes, ok := value[k8sCommonBean.K8sClusterResourceNameKey] | |||
There was a problem hiding this comment.
why are we checking K8sClusterResourceNameKey for service value?
There was a problem hiding this comment.
changed K8sClusterResourceNameKey to K8sClusterResourceMetadataNameKey
|
Kudos, SonarCloud Quality Gate passed!
|
vikramdevtron
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes correctly maps port list with service names in case of helm deployed applications
Fixes #4025
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?