chore: artifact api refactoring #4137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gireesh-devtron
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
| var wfrList []CdWorkflowRunner | ||
| err := impl.dbConnection. | ||
| Model(&wfrList). | ||
| Column("cd_workflow_runner.*", "CdWorkflow", "CdWorkflow.Pipeline", "CdWorkflow.CiArtifact"). | ||
| Where("cd_workflow.pipeline_id = ?", pipelineId). | ||
| Where("cd_workflow_runner.workflow_type = ?", runnerType). | ||
| Where("ci_artifact.image ILIKE %?%", searchString). |
There was a problem hiding this comment.
this should be conditional, otherwise slows the query even if not required
| @@ -278,6 +292,19 @@ func (impl *CiWorkflowRepositoryImpl) FindLastTriggeredWorkflowGitTriggersByArti | |||
| return workflow, err | |||
| } | |||
|
|
|||
| func (impl *CiWorkflowRepositoryImpl) FindLastTriggeredWorkflowGitTriggersByArtifactIds(ciArtifactIds []int) ([]*CiWorkflow, error) { | |||
There was a problem hiding this comment.
func name should be the operation it is performing.
|
|
||
| artifactIds := make([]int, 0, len(ciArtifacts)) | ||
| for _, artifact := range ciArtifacts { | ||
| artifactIds = append(artifactIds, artifact.Id) |
There was a problem hiding this comment.
using append on already initialized array with size n, is not efficient.
… emptyexclude artifacts ids
gireesh-devtron
changed the title
|
SonarCloud Quality Gate failed.
|
gireesh-devtron
changed the title
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
kripanshdevtron
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Artifacts listing api refactoring.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?