Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upload and download logs/artifact from blob storage configured in external cluster #4138

Merged
merged 30 commits into from
Oct 31, 2023

Conversation

prakash100198
Copy link
Contributor

@prakash100198 prakash100198 commented Oct 20, 2023

Description

Currently, we support pushing and getting logs , caches and artifacts from the blob storage configured in the cluster where devtron is installed but when I'm using system executor, we should let people push and get logs, caches and artifacts in external cluster env in blob storage configured in ext cluster. This pr aims at introducing that feature.

Fixes #4184

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  1. aws configured in cluster where devtron is installed and azure installed in ext cluster.
  2. aws configured in cluster where devtron is installed and aws installed in ext cluster, using user access key and secret key.
  3. aws configured in ext cluster using IAM role
  4. aws configured in cluster where devtron is installed and gcp installed in ext cluster.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


pkg/pipeline/CdHandler.go Outdated Show resolved Hide resolved
pkg/pipeline/CdHandler.go Outdated Show resolved Hide resolved
pkg/pipeline/CdHandler.go Outdated Show resolved Hide resolved
pkg/pipeline/CdHandler.go Outdated Show resolved Hide resolved
pkg/pipeline/CdHandler.go Outdated Show resolved Hide resolved
pkg/pipeline/CdHandler.go Outdated Show resolved Hide resolved
pkg/pipeline/CdHandler.go Outdated Show resolved Hide resolved
pkg/pipeline/CdHandler.go Outdated Show resolved Hide resolved
pkg/pipeline/CdHandler.go Outdated Show resolved Hide resolved
pkg/pipeline/CdHandler.go Outdated Show resolved Hide resolved
pkg/pipeline/WorkflowService.go Outdated Show resolved Hide resolved
pkg/pipeline/WorkflowUtils.go Outdated Show resolved Hide resolved
pkg/pipeline/bean/CloudHelperBean.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prakash100198 prakash100198 merged commit 9e5a4ac into main Oct 31, 2023
5 checks passed
@prakash100198 prakash100198 deleted the ext-cluster-blob-issue branch October 31, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants