fix: inducing overridden DockerRegistryId in case docker registry is overridden #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakash100198
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
prakash100198
changed the title
| } | ||
|
|
||
| if ciPipeline.CiTemplate == nil { | ||
| impl.logger.Warn("returning as ciPipeline.CiTemplate is found nil") |
There was a problem hiding this comment.
what is response in this case
| dockerRegistryId := ciPipeline.CiTemplate.DockerRegistryId | ||
| if len(*dockerRegistryId) == 0 { | ||
| impl.logger.Warn("returning as dockerRegistryId is found empty") | ||
| return nil, nil |
There was a problem hiding this comment.
This custom error was not being thrown earlier also, so don't know it may impact other flows also outside this function which will increase the scope of this maybe
vikramdevtron
previously approved these changes
Oct 30, 2023
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
|
Kudos, SonarCloud Quality Gate passed!
|
subhashish-devtron
approved these changes
Oct 30, 2023
vikramdevtron
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we override the base build config (docker registry), at the time of inducing the image pull secret in the manifest we only checked for base build config, and not the overridden docker registry config. This pr aims at fixing the same issue.
Fixes #4179
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?