Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Filter Condition Doc #4224

Merged
merged 3 commits into from
Nov 17, 2023
Merged

docs: Filter Condition Doc #4224

merged 3 commits into from
Nov 17, 2023

Conversation

ashokdevtron
Copy link
Contributor

No description provided.

abhibhaw
abhibhaw requested changes Nov 8, 2023
View reviewed changes
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should include other example conditions than contains

docs/user-guide/global-configurations/filter-condition.md Show resolved Hide resolved
docs/user-guide/global-configurations/filter-condition.md Outdated Show resolved Hide resolved
docs/user-guide/global-configurations/filter-condition.md Outdated Show resolved Hide resolved
docs/user-guide/global-configurations/filter-condition.md Show resolved Hide resolved
docs/user-guide/global-configurations/filter-condition.md Outdated Show resolved Hide resolved
docs/user-guide/global-configurations/filter-condition.md Outdated Show resolved Hide resolved
docs/user-guide/global-configurations/filter-condition.md Outdated Show resolved Hide resolved
@ashokdevtron
Copy link
Contributor Author

We should include other example conditions than contains

Done. Replaced with better examples...

abhibhaw
abhibhaw requested changes Nov 10, 2023
View reviewed changes
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just filter varaibles description needs data type correction

docs/user-guide/global-configurations/filter-condition.md Outdated Show resolved Hide resolved
docs/user-guide/global-configurations/filter-condition.md Outdated Show resolved Hide resolved
docs/user-guide/global-configurations/filter-condition.md Outdated Show resolved Hide resolved
docs/user-guide/global-configurations/filter-condition.md

Consider a scenario where you wish to make an image eligible for deployment only if its tag version is greater than `v0.0.7`

The CEL Expression should be `containerImageTag > "v0.0.7"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a wrong syntax, greater less than should work with numbers 🤔

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

abhibhaw
abhibhaw approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ashokdevtron 🎉

@prakarsh-dt prakarsh-dt changed the title Docs: Filter Condition Doc docs: Filter Condition Doc Nov 17, 2023
@prakarsh-dt prakarsh-dt merged commit e0d95a1 into main Nov 17, 2023
6 of 7 checks passed
@prakarsh-dt prakarsh-dt deleted the filter-cel branch November 17, 2023 08:20
@prakarsh-dt prakarsh-dt restored the filter-cel branch November 17, 2023 08:23
@prakarsh-dt
Copy link
Collaborator

Is this the first time we are adding this page?
We will need to include it in SUMMARY.md for it to appear on the side-menu.
@ashokdevtron

@ashokdevtron
Copy link
Contributor Author

Is this the first time we are adding this page? We will need to include it in SUMMARY.md for it to appear on the side-menu. @ashokdevtron

@prakarsh-dt, sorry...my bad...
Another PR raised for the fix: #4253
Can you please approve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhibhaw abhibhaw abhibhaw approved these changes

@prakarsh-dt prakarsh-dt prakarsh-dt approved these changes

@uxarya-d uxarya-d Awaiting requested review from uxarya-d uxarya-d is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashokdevtron @prakarsh-dt @abhibhaw