Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Added Application Groups Doc #4275

Merged
merged 4 commits into from
Dec 6, 2023
Merged

doc: Added Application Groups Doc #4275

merged 4 commits into from
Dec 6, 2023

Conversation

ashokdevtron
Copy link
Contributor

No description provided.

@ashokdevtron ashokdevtron changed the title Doc: Added Application Groups Doc doc: Added Application Groups Doc Nov 22, 2023
abhibhaw
abhibhaw requested changes Nov 23, 2023
View reviewed changes
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RBAC is missing, who can create filters, who can trigger builds, what if I don't have same permission on all applications etc.

@ashokdevtron
Copy link
Contributor Author

RBAC is missing, who can create filters, who can trigger builds, what if I don't have same permission on all applications etc.

Done 👍

abhibhaw
abhibhaw previously approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uxarya-d Please confirm on the RBAC

uxarya-d
uxarya-d requested changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@uxarya-d uxarya-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls check comments

docs/user-guide/application-groups.md Outdated Show resolved Hide resolved
docs/user-guide/application-groups.md Outdated Show resolved Hide resolved
docs/user-guide/application-groups.md Outdated Show resolved Hide resolved
docs/user-guide/application-groups.md Outdated Show resolved Hide resolved
docs/user-guide/application-groups.md Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@prakarsh-dt prakarsh-dt merged commit 6f18f2e into main Dec 6, 2023
6 checks passed
@prakarsh-dt prakarsh-dt deleted the app-group branch December 6, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uxarya-d uxarya-d uxarya-d approved these changes

@abhibhaw abhibhaw abhibhaw left review comments

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashokdevtron @abhibhaw @uxarya-d @prakarsh-dt