Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:Not able to change Authentication Type for Prometheus. #4284

Merged
merged 8 commits into from
Dec 7, 2023
Merged

fix:Not able to change Authentication Type for Prometheus. #4284

merged 8 commits into from
Dec 7, 2023

Conversation

adi6859
Copy link
Contributor

@adi6859 adi6859 commented Nov 24, 2023

Description

Once cluster is save with Prometheus and auth-type as basic then afterwards not able to change it from basic auth to
Anonymous.

Fixes #874

How Has This Been Tested?

  • tests are performed locally.
  • tests are also done by deploying image on vm.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

vikramdevtron
vikramdevtron previously approved these changes Nov 27, 2023
View reviewed changes
subhashish-devtron
subhashish-devtron previously approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@subhashish-devtron subhashish-devtron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adi6859 adi6859 merged commit ecf1248 into main Dec 7, 2023
5 checks passed
@adi6859 adi6859 deleted the prometh-cluster branch December 7, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@subhashish-devtron subhashish-devtron subhashish-devtron approved these changes

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron kripanshdevtron is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not able to change Authentication Type for Prometheus.
3 participants
@adi6859 @vikramdevtron @subhashish-devtron